Repository navigation
feat(extensions): give panes the current line's source address - #940
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR advances the extension API to v14 and exposes the current cursor’s
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, compatibility, or security issues identified. The pane fields are derived from the same live cursor target used for command selection, publication is guarded by matching cursor identity, and the API version, exports, package check, tests, and documentation remain aligned. Important Files Changed
Reviews (1): Last reviewed commit: "feat(extensions): give panes the current..." | Re-trigger Greptile |
benvinegar
force-pushed
the
feat/pane-current-line-address
branch
from
August 31, 2026 00:39
4fa4c27 to
8517d2e
Compare
Opted-in currentLine paint already follows the cursor, but only as a row painter. Add side and line — the same public address command selection already carries — so a pane can look up blame or diagnostics without waiting for a keypress.
benvinegar
force-pushed
the
feat/pane-current-line-address
branch
from
August 31, 2026 00:40
8517d2e to
c8a9b37
Compare
benvinegar
enabled auto-merge (squash)
August 31, 2026 00:41
1 task
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opted-in pane
currentLinealready follows the cursor, but only as an opaque row painter (render(side, width)). Commands already get{ side, line }onctx.selection.currentLine. Panes did not, so anything that needs the address — blame, diagnostics, notes — could not update as the user stepped.This adds
sideandlinetoExtensionCurrentLinePaint(API v14). Same opt-in (currentLine: true), same public address as command selection andrevealLine. Lens keeps calling.render(); a blame pane can read the address.Test plan
bun test src/ui/lib/extensionCurrentLine.test.ts src/ui/lib/extensionPanes.test.ts src/ui/hooks/useExtensionPaneController.test.tsx src/extensions/runExtension.test.tshunk extension install modem-dev/hunk-lens) and confirm the bottom lens still follows the current linecurrentLine: truethatnotifys${currentLine.side}:${currentLine.line}on each step