Repository navigation
feat(ui): add responsive pane sizing - #924
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR adds bounded fractional sizing for extension panes and makes the bundled file sidebar grow responsively while preserving manual overrides.
Confidence Score: 5/5The PR appears safe to merge with responsive pane allocation, manual resizing, extension validation, and layout transitions covered coherently. Fractional and manual targets are bounded by pane constraints and available review capacity, axis changes cannot reuse incompatible overrides, and the public API, bundled sidebar, documentation, and tests remain aligned. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Terminal body axis] --> B{Manual override?}
B -->|Yes| C[Use axis-matched cell override]
B -->|No| D{Fraction configured?}
D -->|Yes| E[Round body axis × fraction]
D -->|No| F[Use preferred cells]
C --> G[Apply min and max bounds]
E --> G
F --> G
G --> H[Clamp to remaining review capacity]
H --> I{Minimum still satisfied?}
I -->|Yes| J[Allocate pane and divider]
I -->|No| K[Omit pane]
Reviews (1): Last reviewed commit: "feat(ui): add responsive pane sizing" | Re-trigger Greptile |
1 task
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the bundled file sidebar grow with the terminal while preserving host-planned pane geometry and manual resizing. The same bounded fractional sizing is available to bundled and user extension panes through extension API v12.
Automatic layout now treats sidebar visibility and diff layout as independent transitions:
>= 220160–219120–159< 120Explicit split/stack modes remain authoritative, and users can still force the sidebar open below its automatic cutoff.
Approach
ExtensionPaneSize.fractionand validate finite values in(0, 1].preferredsizing.fraction.Verification
git ls-files -z | xargs -0 bunx oxfmt --checkbun run lintbun run typecheckbun run deps:checkbun run test— 2059 passed, 10 skippedbun run test:integration— 137 passed, 1 platform skipbun run test:tty-smoke— 9 passedbun run check:docsbun run website:checkbun run build:npmbun run check:packReal-PTY coverage exercises live resizing through expanded, compact, sidebar-free split, and stack states, plus forced visibility and divider dragging. Tested on Linux. Independent review found no blockers.
Follow-up
Resetting a manually resized pane back to automatic sizing via double-click or a menu action remains out of scope.
This PR description was generated by Pi using gpt-5.6-sol