refactor(ui): isolate extension dialog lifecycle

[benvinegar]

Summary

• extract extension dialog state and lifecycle management from App into useExtensionDialogController
• keep the dialog queue private while exposing the narrow createDialogs capability used by extension commands
• add focused coverage for request promotion, soft-reload cancellation, and unmount shutdown

Testing

• bun run typecheck
• bun run format:check
• bun run lint
• bun run test (1,748 passed, 9 skipped)

This PR description was generated by Pi using GPT-5.4

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hunk-web	Ready	Preview	Jul 31, 2026 3:39pm

[greptile-apps]

Greptile Summary

This PR isolates extension-dialog state and lifecycle management in a dedicated controller hook.

• Moves queue ownership, answer state, request promotion, reload cancellation, and unmount shutdown out of App.
• Exposes only the dialog-capability factory and UI-facing controller actions.
• Adds focused tests for request handling, soft reloads, and teardown.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The extracted controller preserves the prior queue ownership, callback behavior, request-state resets, reload cancellation, and unmount cleanup, with focused tests covering the lifecycle boundaries.

Important Files Changed

Filename	Overview
src/ui/App.tsx	Replaces inline extension-dialog lifecycle management with the controller hook while preserving command, keyboard, and rendering integration.
src/ui/hooks/useExtensionDialogController.ts	Encapsulates the stable queue, per-request answer state, soft-reload cancellation, and unmount shutdown without changing existing behavior.
src/ui/hooks/useExtensionDialogController.test.tsx	Adds focused coverage for FIFO request promotion, answer-state reset, reload cancellation, post-reload reuse, and unmount settlement.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Command[Extension command] --> Create[createDialogs]
  Create --> Queue[Private dialog queue]
  Queue --> Request[Visible request]
  Request --> UI[Extension dialog UI]
  UI --> Accept[Accept or cancel]
  Accept --> Queue
  Reload[Review generation changes] --> CancelAll[cancelAll]
  CancelAll --> Queue
  Unmount[App unmounts] --> Shutdown[shutdown]
  Shutdown --> Queue

Loading

_{Reviews (1): Last reviewed commit: "refactor(ui): isolate extension dialog l..." | Re-trigger Greptile}