Repository navigation
Fix/draft note focus transition - #1125
Merged
benvinegar merged 2 commits intoOct 11, 2026
Merged
Conversation
Typing that arrives in the same input chunk as the key or click that opens a note draft was dispatched as global commands: the editor takes keyboard ownership in a later render, so the characters never reached the note and unrelated commands ran instead. Buffer printable keys for the draft, deliver them when the editor takes focus, and honor Escape and Ctrl-S inside the same window.
|
@codex is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
igshehata
marked this pull request as ready for review
September 25, 2026 07:15
Contributor
|
PR author is not in the allowed authors list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I first noticed this in pi-hunk: typing immediately after opening an inline comment could trigger global shortcuts instead of entering text. Closing and reopening the editor appeared to resolve it.
Investigation traced the problem back to Hunk’s terminal input/focus handling, and it reproduces in standalone Hunk without pi-hunk.
There is a window between opening a draft and its editor mounting and receiving focus. Printable input arriving during that window can be handled as global shortcuts or lost. For example, sending
csnotein one terminal input burst should open a draft containingsnote; instead, it cantoggle the sidebar and open the theme selector.