Repository navigation
fix(nix): install hunkdiff alias so hunk patch works - #1108
Merged
benvinegar merged 1 commit intoSep 23, 2026
Merged
Conversation
The 0.22 review flows respawn the TUI through a hunkdiff lookup, mirroring the npm package's dual hunk/hunkdiff bins. The Nix package installed only hunk, so hunk patch failed with "unable to execute '.../bin/hunkdiff'". Install hunkdiff as a symlink to the wrapped hunk binary. agent-identity: dev3.direct.omp.udckw4nk agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.1.14 agent-runtime: OMP 18.1.14 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@183d780
Contributor
|
PR author is not in the allowed authors list. |
|
@schickling-assistant is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and user impact
Since 0.22.0,
hunk patch <file>(and other review flows that respawn the TUI) fail under the Nix flake package with:hunk --version/--help/skill pathstill work. v0.21.1 works with the identical install layout. Reported as #1106.Approach
The review flows resolve the TUI through a
hunkdifflookup, mirroring the npm package's dualhunk/hunkdiffbins (same./bin/hunk.cjs). The NixinstallPhaseonly installedhunk, so the lookup fails. This change installshunkdiffas a symlink to the wrappedhunkbinary (wrapper env, includingHUNK_INSTALL_SOURCE=nix, is preserved through the symlink).Non-goals: no behavior change to any other install path (npm, curl, Homebrew); no new package output.
Tests and manual checks performed
nix build .#hunk --no-linkon x86_64-linux: builds clean.hunk patch /tmp/smoke.patchfrom the fixed package with a cleanPATH(package bin only): renders the review TUI, exit 0. Before the fix: theunable to execute …/bin/hunkdifferror.hunk --versionandhunkdiff --versionboth report the packaged version.nix/package.nix(no TypeScript), and the failure/success is fully determined by the installed file layout, verified above.Platforms
Follow-up
Once merged, downstream Nix consumers can advance past the v0.21.1 hold.
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktreetooling_profile