Skip to content

test(ui): harden job control resume coverage - #1010

Merged
benvinegar merged 1 commit into
mainfrom
test/job-control-resume-hardening
Sep 6, 2026
Merged

benvinegar merged 1 commit into
mainfrom
test/job-control-resume-hardening

Conversation

@benvinegar

Copy link
Copy Markdown
Member

Summary

  • add PTY coverage for directly launched Hunk when an orphaned process group discards SIGTSTP
  • wait for observable keyboard readiness after fg instead of fixed redraw sleeps
  • scope the job-control ordering comment to the normal shell-managed path

Follow-up to #996. This does not change production job-control behavior.

Validation

  • ./node_modules/.bin/bun run typecheck
  • ./node_modules/.bin/bun run test
  • ./node_modules/.bin/bun run test:integration
  • ./node_modules/.bin/bun run lint
  • ./node_modules/.bin/bun run deps:check
  • ./node_modules/.bin/bun run format:check

Validated locally on Linux. The merged fix was also reproduced before/after under Firecracker v1.16.1 with Linux 6.18.44.

@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
hunk-web Ignored Ignored Sep 6, 2026 2:25pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR strengthens PTY coverage for job-control resume behavior without changing production behavior.

  • Adds a direct-launch regression test for discarded SIGTSTP in an orphaned process group.
  • Replaces fixed post-resume redraw sleeps with observable keyboard-readiness checks.
  • Clarifies that synchronous stop behavior applies to the normal shell-managed path.
  • Adds an empty maintenance Changeset.

Confidence Score: 5/5

The PR appears safe to merge; the changes are limited to test hardening, explanatory documentation, and release metadata.

The new readiness checks require observable Hunk keyboard handling, the direct-launch case exercises continued responsiveness after Ctrl-Z, and no production logic or concrete regression was introduced.

Important Files Changed

Filename Overview
test/pty/lifecycle.test.ts Adds direct-launch SIGTSTP coverage and uses application-driven readiness checks to stabilize shell resume assertions.
packages/hunk/src/core/process/jobControl.ts Narrows existing job-control documentation to distinguish normal shell-managed suspension from discarded SIGTSTP.
.changeset/steady-job-control-tests.md Records the test-only maintenance change with an empty Changeset.

Reviews (1): Last reviewed commit: "test(ui): harden job control resume cove..." | Re-trigger Greptile

@benvinegar
benvinegar merged commit 1fd966a into main Sep 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant