Skip to content

hunk diff doesn't show "unchanged files" after the last change #1154

Open

Description

@mocheng

What happened?

version 0.23.0

In Hunk UI, there is no "unrecognized lines" after the last change in one file.

Steps to reproduce

Suppose there is a file with some change. The git diff output:

diff --git a/tippe_top.py b/tippe_top.py
index d808307..117cca7 100644
--- a/tippe_top.py
+++ b/tippe_top.py
@@ -2,6 +2,7 @@ import time
 import mujoco
 import mujoco.viewer

+
 tippe_top = """
 <mujoco model="tippe top">
   <option integrator="RK4"/>
@@ -45,6 +46,7 @@ mujoco.mj_resetDataKeyframe(model, data, key_id)
 #mujoco.mj_resetDataKeyframe(model, data, 0)
 mujoco.mj_forward(model, data)

+
 with mujoco.viewer.launch_passive(model, data) as viewer:
     viewer.opt.flags[mujoco.mjtVisFlag.mjVIS_JOINT] = True
     cam_id = mujoco.mj_name2id(model, mujoco.mjtObj.mjOBJ_CAMERA, "closeup")
(END)

In hunk diff, the UI is like this:

Image

Expected behavior

I would be appreciated that it also enable expand "unrecognized lines" from the last changed line to end of file.

Version

0.23.0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions