fix: Fix bug in EarlyStop plugin patience counter

[HuChundong]

PR type

• Bug Fix
• New Feature
• Document Updates
• More Models or Datasets Support

PR information

The patience counter in the EarlyStopping plugin was not reset after a new best loss was found, leading to premature termination of training. This patch resets the counter on improvement.

Experiment results

Paste your experiment result here(if needed).

[gemini-code-assist]

Summary of Changes

Hello @HuChundong, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've implemented a critical bug fix for the EarlyStop plugin. Previously, the patience counter was not resetting when the model achieved a new best performance metric, which could cause training to terminate prematurely. This change ensures that the counter correctly resets upon improvement, allowing the training process to continue as expected and preventing unintended early stopping.

Highlights

• EarlyStop Plugin Bug Fix: I've addressed a bug in the EarlyStop plugin where the patience counter (self.interval) was not being reset when a new best metric was achieved. This oversight could lead to training stopping prematurely.
• Patience Counter Reset: The fix involves adding a line to reset self.interval to 0 immediately after self.best_metric is updated, ensuring the patience mechanism functions as intended.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug in the EarlyStopCallback where the patience counter (self.interval) was not being reset when a new best metric was found. This could lead to premature termination of training. The change introduces the necessary reset of the counter, ensuring the early stopping logic functions as intended. The fix is concise and effectively resolves the issue.