fix PPO #2377
Merged
fix PPO #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it still in WIP status, or can it be reviewed now |
It's still under testing now |
hjh0119
commented
Nov 10, 2024
Comment on lines
+1798
to
+1824
| from contextlib import nullcontext, contextmanager | ||
|
|
||
| @contextmanager | ||
| def ppocontext(): | ||
| from transformers.integrations.deepspeed import HfTrainerDeepSpeedConfig | ||
| from transformers.utils import is_sagemaker_mp_enabled | ||
| if is_sagemaker_mp_enabled(): | ||
| import smdistributed.modelparallel.torch as smp | ||
| smp.init() | ||
| old_trainer_config_process = HfTrainerDeepSpeedConfig.trainer_config_process | ||
|
|
||
| def trainer_config_process(self, args, auto_find_batch_size=False): | ||
| if args.world_size is None: | ||
| if args.distributed_state is not None: | ||
| return args.distributed_state.num_processes | ||
| elif is_sagemaker_mp_enabled(): | ||
| return smp.dp_size() if not smp.state.cfg.prescaled_batch else smp.rdp_size() | ||
| return 1 | ||
| return old_trainer_config_process(self, args, auto_find_batch_size) | ||
|
|
||
| HfTrainerDeepSpeedConfig.trainer_config_process = trainer_config_process | ||
| yield | ||
| HfTrainerDeepSpeedConfig.trainer_config_process = old_trainer_config_process | ||
|
|
||
| context = nullcontext if self.rlhf_type != 'ppo' else ppocontext | ||
| with context(): | ||
| super().__post_init__() |
Jintao-Huang
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
PR information
related issue:
#2316
#2296
#2330
#2285
Experiment results
Paste your experiment result here(if needed).