Fix olora and pissa saving files which will cause the second saving failed #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jintao-Huang
approved these changes
Sep 13, 2024
Jintao-Huang
approved these changes
Sep 13, 2024
…a_olora * commit '88dab2b6625280e813bd8835662e1d2be24a3132': fix deploy eval kill (modelscope#2029) update code (modelscope#2028) refactor rlhf (modelscope#1975) Florence use post_encode & template support encoder-decoder (modelscope#2019) Add FAQ Document (modelscope#2013) fix lmdeploy qwen_vl (modelscope#2009) # Conflicts: # swift/trainers/mixin.py
tastelikefeet
added a commit
that referenced
this pull request
Sep 13, 2024
…actor3 * commit 'e46cda27abc5122402394b50e03b3d61ec04d0dc': Fix olora and pissa saving files which will cause the second saving failed (#2032) fix deploy eval kill (#2029) update code (#2028) refactor rlhf (#1975) Florence use post_encode & template support encoder-decoder (#2019) # Conflicts: # examples/customization/custom.py # examples/pytorch/llm/scripts/dpo/lora/dpo.sh # examples/pytorch/llm/scripts/dpo/lora_ddp_mp/dpo.sh # swift/llm/model/model.py # swift/trainers/push_to_ms.py
tastelikefeet
added a commit
that referenced
this pull request
Sep 14, 2024
* commit '08d9ef4f04970e934ce375394205703214ede606': fix rlhf & zero3 (#2034) Fix olora and pissa saving files which will cause the second saving failed (#2032) fix deploy eval kill (#2029) update code (#2028) refactor rlhf (#1975) Florence use post_encode & template support encoder-decoder (#2019) Add FAQ Document (#2013) fix lmdeploy qwen_vl (#2009) Support llava1.6-llama3.1-8b-instruct (#2005) Fix rlhf ref model (#2003) compat lmdeploy==0.6 (#2001) fix EngineGenerationConfig importError of lmdeploy (#1990) Support Deepseek 2.5 (#1992) fix eval is_multimodal (#1995) fix patch (#1997) fix model_mapping (#1982)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).