-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix and feature #439
Merged
Merged
bugfix and feature #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jiaqianjing
commented
May 15, 2024
•
edited
Loading
edited
- add traceback info when call llm failed at the retry decorator;
- add zhipu function call at the no_stream mode;
- remove useless code;
![image](https://private-user-images.githubusercontent.com/16071449/330725101-51169704-e02f-4625-b186-544dbb2087a4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NTMxMzgsIm5iZiI6MTczOTQ1MjgzOCwicGF0aCI6Ii8xNjA3MTQ0OS8zMzA3MjUxMDEtNTExNjk3MDQtZTAyZi00NjI1LWIxODYtNTQ0ZGJiMjA4N2E0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDEzMjAzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM1MDZiOGExMTYyYTlmZDkzNDA1NjJjY2QwZTVhOTQyNGJhN2ZiNWY0ODQzN2Q1ZDVlZWQ3NDdlYjMyNmQ4NDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.2RQHud--sBD0l3N2758jbMZK4PXE9ynpyDzW94n7eMA)
… add zhipu function call at the no_stream mode
能不能把你们的 citest 调好,提了那么多次都不成功,完全没有在想贡献的欲望 |
这里我们想想怎么优化,这里加了一些secrets调用,会导致fork进来的pr,都有这个问题,我们看看怎么拆开这部分吧。 |
请合并最新的master,已经解决forked repo ci 不通过问题。感谢支持。 |
|
||
|
||
@register_llm('glm-4') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to keep this @register_llm('glm-4') with @register_llm('zhipu')
zzhangpurdue
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.