Skip to content

fix qwen image max rope index to 10000 #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tenderness-git merged 1 commit into from
Aug 8, 2025
Merged

fix qwen image max rope index to 10000 #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions diffsynth_engine/models/qwen_image/qwen_image_dit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ def __init__(
super().__init__()
self.theta = theta
self.axes_dim = axes_dim
pos_index = torch.arange(1024)
neg_index = torch.arange(1024).flip(0) * -1 - 1
pos_index = torch.arange(10000)
neg_index = torch.arange(10000).flip(0) * -1 - 1
Comment on lines +51 to +52
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The value 10000 is used as a magic number in two places. To improve readability and maintainability, it would be better to define it as a named constant at the module or class level. This makes the purpose of the number clear and simplifies future modifications.

For example:

# At module level
MAX_ROPE_INDEX = 10000

# In __init__
pos_index = torch.arange(MAX_ROPE_INDEX)
neg_index = torch.arange(MAX_ROPE_INDEX).flip(0) * -1 - 1

self.pos_freqs = torch.cat(
[
self.rope_params(pos_index, self.axes_dim[0], self.theta),
Expand Down