Skip to content

Specify a distinct base package for the model-server example #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nkoester merged 1 commit into from
Nov 17, 2022
Merged

Specify a distinct base package for the model-server example #21

nkoester merged 1 commit into from
Nov 17, 2022

Conversation

@languitar
Copy link
Contributor

@languitar languitar commented Nov 17, 2022

Avoid polluting the general sample package namespace by moving the Quarkus example in a sub-package.

@languitar
Add a specific package for model-server example
95504d6 
Avoid polluting the general sample package namespace by moving the
Quarkus example in a sub-package.
@languitar languitar requested a review from nkoester November 17, 2022 10:21
nkoester
nkoester approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@nkoester nkoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkoester nkoester merged commit c9a977d into main Nov 17, 2022
@nkoester nkoester deleted the bugfix/quarkus-base-package branch November 17, 2022 10:57
@nkoester nkoester mentioned this pull request Dec 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkoester nkoester nkoester approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

M1: Release version 1.0 of samples

Development

Successfully merging this pull request may close these issues.

2 participants

@languitar @nkoester