Single page application using openapi spec #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkoester
changed the title
Member
Author
|
Readme is still missing. To start run |
languitar
reviewed
Nov 13, 2022
spa-dashboard-angular/src/app/lecture-detail/lecture-detail.component.html
Show resolved
Hide resolved
Remove commented code Co-authored-by: Johannes Wienke <languitar@semipol.de>
Remove commented code Co-authored-by: Johannes Wienke <languitar@semipol.de>
…kus API implementation
Member
Author
|
Its good enough for now. Will need documentation and external port config for full integration. |
languitar
approved these changes
Nov 15, 2022
Contributor
languitar
left a comment
languitar
left a comment
There was a problem hiding this comment.
Just some minor ideas. The rest is fine.
* Extract URL encoding to helper function * Remove trailing spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet fully testes with MPS but with prism mock server using the openapi spec, started via
docker run --rm -p 4010:4010 -v /tmp/openapi.yaml:/tmp/openapi.yaml:ro stoplight/prism mock -h 0.0.0.0 -d /tmp/openapi.yaml