Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributors #1742

Merged
merged 13 commits into from
Apr 22, 2022
Merged

Contributors #1742

merged 13 commits into from
Apr 22, 2022

Conversation

chrbertsch
Copy link
Collaborator

@chrbertsch chrbertsch commented Apr 13, 2022 •
edited
Loading

Contributors to FMI3.0.
Please add yourself or others.

@chrbertsch chrbertsch added help wanted Extra attention is needed documents labels Apr 13, 2022
@chrbertsch chrbertsch added this to the v3.0-rc.2 milestone Apr 13, 2022
@chrbertsch chrbertsch linked an issue Apr 13, 2022 that may be closed by this pull request
Fix acknowledgements before release of FMI3.0 #1737
Closed
otronarp
otronarp reviewed Apr 13, 2022
View reviewed changes
docs/7___appendix.adoc Outdated Show resolved Hide resolved
@chrbertsch @otronarp
Update docs/7___appendix.adoc
ed0ce4f 
Co-authored-by: Otto Tronarp <otto@tronarp.se>
pmai
pmai reviewed Apr 13, 2022
View reviewed changes
docs/7___appendix.adoc Outdated Show resolved Hide resolved
pmai
pmai reviewed Apr 13, 2022
View reviewed changes
docs/7___appendix.adoc Outdated Show resolved Hide resolved
pmai
pmai reviewed Apr 13, 2022
View reviewed changes
docs/7___appendix.adoc Outdated Show resolved Hide resolved
pmai
pmai reviewed Apr 13, 2022
View reviewed changes
docs/7___appendix.adoc Outdated Show resolved Hide resolved
beutlich
beutlich reviewed Apr 13, 2022
View reviewed changes
docs/7___appendix.adoc Outdated Show resolved Hide resolved
docs/7___appendix.adoc Outdated Show resolved Hide resolved
docs/7___appendix.adoc Outdated Show resolved Hide resolved
chrbertsch and others added 3 commits April 13, 2022 14:57
@chrbertsch @beutlich
Update docs/7___appendix.adoc
c97bbd3 
Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
@chrbertsch @beutlich
Update docs/7___appendix.adoc
e5aafd8 
Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
@chrbertsch @beutlich
Update docs/7___appendix.adoc
305aa42 
Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
beutlich
beutlich reviewed Apr 19, 2022
View reviewed changes
docs/7___appendix.adoc Outdated Show resolved Hide resolved
beutlich
beutlich reviewed Apr 19, 2022
View reviewed changes
docs/7___appendix.adoc Outdated Show resolved Hide resolved
chrbertsch and others added 3 commits April 19, 2022 20:04
@chrbertsch @beutlich
Update docs/7___appendix.adoc
0ffa168 
Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
@chrbertsch @beutlich
Update docs/7___appendix.adoc
4cf9a62 
Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
@chrbertsch
Update 7___appendix.adoc
6d96ed1
@chrbertsch chrbertsch marked this pull request as ready for review April 21, 2022 06:39
@TorstenBlochwitz
Copy link

  1. Shouldn't we add reference to the contributors to FMI 1.0 and 2.0?
  2. In FMI 2.0 we mention the tool prototypes which were used to evaluate the standard. I propose to do the same to honor the effort done by the contributors.
  3. I need an additional acknowledgement: "Contributions of ESI ITI GmbH were carried out within the project FMI4BIM, funded by the German Federal Ministry for Economic Affairs and Energy." I need to take a look to the funding contract if I have to add a logo of the ministry.

@andreas-junghanns andreas-junghanns merged commit dbe1701 into modelica:master Apr 22, 2022
@beutlich beutlich removed the help wanted Extra attention is needed label Apr 26, 2022
@beutlich beutlich removed the request for review from t-sommer April 26, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmai pmai pmai left review comments

@otronarp otronarp otronarp left review comments

@beutlich beutlich beutlich left review comments

@andreas-junghanns andreas-junghanns andreas-junghanns approved these changes

@TorstenBlochwitz TorstenBlochwitz TorstenBlochwitz approved these changes

Assignees
No one assigned
Labels
documents
Projects
None yet
Milestone
v3.0-rc.2
Development

Successfully merging this pull request may close these issues.

Fix acknowledgements before release of FMI3.0
6 participants
@chrbertsch @TorstenBlochwitz @pmai @otronarp @beutlich @andreas-junghanns