Skip to content

Conversation

HansOlsson
Copy link
Contributor

@HansOlsson HansOlsson commented Jan 30, 2025

Found when investigating modelica/ModelicaSpecification#3645
I assume the min=0 is just copy-paste from the Absolute-variant, and no-one tested this.

We might add annotation(absoluteValue=false) if we want to be clear for this one.

@HansOlsson HansOlsson added the L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) label Jan 30, 2025
@HansOlsson HansOlsson changed the title It does not make sense to restrict a temperature difference to be >0 It does not make sense to restrict a temperature difference to be >=0 Jan 30, 2025
Copy link
Contributor

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

@AHaumer AHaumer self-requested a review February 11, 2025 14:49
Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

@HansOlsson HansOlsson merged commit e490653 into modelica:master Feb 11, 2025
2 checks passed
@HansOlsson HansOlsson deleted the RemoveMin branch February 11, 2025 15:59
@beutlich beutlich added this to the MSL4.2.0 milestone Feb 11, 2025
@beutlich
Copy link
Member

Milestone set.

@beutlich beutlich assigned HansOlsson and unassigned casella Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants