Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matio library to 1.5.28 #4497

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

beutlich
Copy link
Member

Follow-up of #4455.

@beutlich beutlich added the L: C-Sources Issue addresses Modelica/Resources/C-Sources label Oct 31, 2024
@beutlich beutlich added this to the MSL4.2.0 milestone Oct 31, 2024
@beutlich beutlich changed the title Update matio 1.5.28 Update matio library to 1.5.28 Oct 31, 2024
@casella
Copy link
Contributor

casella commented Nov 11, 2024

@beutlich do we have an established procedure to test these C-code updates? Do you have suggestions about that? Thanks!

@beutlich
Copy link
Member Author

@beutlich do we have an established procedure to test these C-code updates? Do you have suggestions about that? Thanks!

We have build and test stages (/.CI/Test/TablesFromMatFile.c) via CI.

Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltelenz
Copy link
Contributor

I don't know enough about this part of MSL to make a sensible review.

@maltelenz maltelenz removed their request for review November 14, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: C-Sources Issue addresses Modelica/Resources/C-Sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants