Add abstraction layer for external function of Streams.error #4496
+63
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beutlich
added
L: C-Sources
|
@beutlich can you quickly describe what is the advantage of this solution? Thanks! |
Currently MSL requires that tools provide a library (static or dynamic) named "ModelicaExternalC.*" where symbol "ModelicaError" gets resolved. However, this is not required from MLS perspective. This PR fixes this superfluous requirement. |
This avoids that Modelica utility function ModelicaError has to be provided by library ModelicaExternalC.
beutlich
force-pushed
the
update-streams-error
branch
from
bdf4e0b
to
fd3966e
Compare
|
Is this related to #4476? If so, we should probably try to get a harmonized solution. Or is this an orthogonal issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids that Modelica utility function ModelicaError has to be provided by library ModelicaExternalC.