-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix feature check macros for POSIX realpath #4302
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Seems needed as it seems common to recommend -D_BSD_SOURCE
@beutlich on my system and with the lib creating the problem (open62541), switching to defined(_BSD_SOURCE) did not fix the problem. |
@TeoGoddet Can you please find out why realpath is not available when you expected it to be available? |
@beutlich I don't think that realpath should be available (dymola windows with visual studio 22 compiler) I will try to understand if Open62541 is doing wrong or not with the BSD_SOURCE |
@TeoGoddet OK, waiting for your feedback then. |
@TeoGoddet I also do not understand why would you want to build ua.c (executable) together with ModelicaInternal.c. 😕 |
@beutlich sorry I gave the wrong file, the problematic one is : https://github.com/open62541/open62541/blob/88dbcb6d644aaf3c38d2a1af9fc9cc2755c24c42/arch/win32/ua_architecture.h#L133 |
That header file is 5 years old and not part of current open62541 code. Still being confused. |
@beutlich It end up in the single file version of the lib for some reason (found here https://github.com/open62541/open62541/releases/tag/v1.3.6) On this side I think that this PR is needed to ensure proper handling of |
b59d80e
to
fac8a69
Compare
@TeoGoddet Could you please share a minimal Modelica model and workflow (in a separate repo) that demonstrates your observations? Thanks! |
fac8a69
to
d4526a7
Compare
d4526a7
to
20a5c0a
Compare
20a5c0a
to
da90ab2
Compare
28848d7
to
19dc0db
Compare
19dc0db
to
7620d2f
Compare
7620d2f
to
1c5f3ae
Compare
1c5f3ae
to
b7e1a92
Compare
b7e1a92
to
fb20fb1
Compare
@sjoelund, @adrpo, @AnHeuermann can you please review this and/or comment? I think this is OK but I'm not much into this kind of low-level C programming. |
fb20fb1
to
8887725
Compare
Sorry, I don't know how this POSIX stuff is supposed to work, so I can't give a review. |
Maybe @fedetft could help with that? He for sure knows a thing or two about POSIX 😄 |
Resolves #4301.
This is PR for master that hopefully can get back-ported to main/4.1.0 after merge.