-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RotationalCoupling #4019
base: master
Are you sure you want to change the base?
RotationalCoupling #4019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this implementation is much cleaner. However, the comparisonSignals and test models introduced in #3786 should get removed/updated
I'm convinced with this solution. But sorry for bother you again - I'm still stumbling upon the icon. To me, it makes an impression of a jaw coupling (#4012 (comment)) which in fact enables some very small relative rotation between the two flanges We have obviously different points of view - while I'm focused on that one component only, you consider the whole drive test rig. Located in the |
To have the coupling more obvious in the simulation example it would make sense to add two rotational speed sensors. The doumentation could then refer to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me.
Address #4012:
RotationalCopling
toModelica.Electrical.Machines.Utilities
.IdealGear(ratio=-1)
inside the coupling.