Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reasoning on library design in UsersGuide.StateSelection #3369

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Update reasoning on library design in UsersGuide.StateSelection #3369

merged 1 commit into from
Jan 27, 2020

Conversation

beutlich
Copy link
Member

refs #2946

@beutlich beutlich added L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational documentation Issue addresses the documentation labels Jan 26, 2020
@beutlich beutlich added this to the MSL4.0.0 milestone Jan 26, 2020
@beutlich beutlich self-assigned this Jan 26, 2020
@beutlich beutlich mentioned this pull request Jan 26, 2020
Open
@beutlich beutlich changed the title Update reasoning on library design Update reasoning on library design in UsersGuide.StateSelection Jan 26, 2020
HansOlsson
HansOlsson reviewed Jan 27, 2020
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a clear improvement, but if we have time we could also explain that using appropriate relative positions is better; even if we have the possibility to use absolute error tolerance for the absolute positions. (Since springs, bushings, etc depend on those relative positions.)

tobolar
tobolar approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@tobolar tobolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now.

HansOlsson
HansOlsson approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine! We can wait with the additional changes.

@dietmarw dietmarw merged commit 1703e5b into modelica:master Jan 27, 2020
@dietmarw dietmarw assigned dietmarw and unassigned beutlich Jan 27, 2020
@beutlich beutlich deleted the update-usersguide-stateselection branch January 27, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson approved these changes

@tobolar tobolar tobolar approved these changes

Assignees

@dietmarw dietmarw

Labels
documentation Issue addresses the documentation L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@beutlich @tobolar @HansOlsson @dietmarw