Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper axes orientation and initialization of UniversalSpherical #2926

Merged
merged 1 commit into from
May 20, 2019
Merged

Proper axes orientation and initialization of UniversalSpherical #2926

merged 1 commit into from
May 20, 2019

Conversation

tobolar
Copy link
Contributor

@tobolar tobolar commented May 13, 2019

close #2866

@tobolar tobolar added the L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined label May 13, 2019
@tobolar tobolar added this to the MSL4.0.0 milestone May 13, 2019
@tobolar @beutlich
Change axes orientation and set proper initial angle of joint "univer…
b0fd131 
…sal" in ModelicaTest.MultiBody.Joints.UniversalSpherical
@beutlich beutlich self-assigned this May 13, 2019
HansOlsson
HansOlsson approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@beutlich beutlich requested review from henrikt-ma and removed request for henrikt-ma May 20, 2019 18:35
@beutlich
Copy link
Member

@henrikt-ma Can you please add your review. Thanks.

henrikt-ma
henrikt-ma approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

The missing piece when making this kind of change is that there should be a corresponding pull request on an update of the reference result; In my mind, the person making the change is also the person who should be responsible for suggesting what the updated reference result should be, and reviewers should verify the combination of both changes.

@beutlich
Copy link
Member

The missing piece when making this kind of change is that there should be a corresponding pull request on an update of the reference result; In my mind, the person making the change is also the person who should be responsible for suggesting what the updated reference result should be, and reviewers should verify the combination of both changes.

Currently we do not have such a workflow and changes will be detected late when running the regression tests during the release phase. Therefore, this is for the future.

@beutlich beutlich removed the request for review from MartinOtter May 20, 2019 19:46
@beutlich beutlich merged commit 0855a06 into modelica:master May 20, 2019
@tobolar tobolar deleted the issue2922_TestUniversalSpherical branch May 22, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikt-ma henrikt-ma henrikt-ma approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Axis for ModelicaTest.MultiBody.Joints.UniversalSpherical
4 participants
@tobolar @beutlich @HansOlsson @henrikt-ma