-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade user's guide #2867
Upgrade user's guide #2867
Conversation
Unifying the documentation of the MSL is a very extensive task. We still have a lot of very different formats applied to variables in the documentation of the MSL models (and User's Guides). However, I think it does make sense to step by step unify the appearance. In Everything else looks good. |
@christiankral
So I would follow the recommendation and simply use |
Using Two more comments here:
|
Shall be done now. |
# Conflicts: # Modelica/Mechanics/Translational.mo
# Conflicts: # Modelica/Mechanics/Rotational.mo
I resolved the merge conflicts and clean-up the commit history. @christiankral @AHaumer Please review (again)! @tobolar Is it intentional that Modelica.Mechanics.Translational.UsersGuide.StateSelection speaks about angles as state variables? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, looks all good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional that Modelica.Mechanics.Translational.UsersGuide.StateSelection speaks about angles as state variables?
Well in many components the following is used: |
@tobolar Can you please reply on this open comment? |
@beutlich Fixed now. Thanks! |
OK, going to merge. The real issue still is mentioned in #2946 and I'd like to see @tobolar's and @MartinOtter's input there. |
For both Rotational and Translational libraries from Modelica.Mechanics.
This concerns the documentation text itself as well as proper html format (e.g.
"
instead of"
, etc.)close #2813