Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSL 4.1.0 Regressions - Mechanics.Rotational and Mechanics.Translational #4340

Open
2 of 3 tasks
GallLeo opened this issue Feb 27, 2024 · 3 comments
Open
2 of 3 tasks
Assignees
Labels
example Issue only addresses example(s) L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases)
Milestone

Comments

@GallLeo
Copy link
Contributor

GallLeo commented Feb 27, 2024

The following models fail in result comparison.
Tested revision: f9bddf8 (2024-02-16)

Changed models, need reference update after library officer check:

  • Modelica.Mechanics.Rotational.Examples.EddyCurrentBrake
    - Reason: The component has been enhanced in a backwards compatible way with an optional excitation input, which is demonstrated by this upgraded example. @GallLeo pls. create new reference results.
    - Updated reference files?

  • Modelica.Mechanics.Translational.Examples.EddyCurrentBrake
    - Reason: The component has been enhanced in a backwards compatible way with an optional excitation input, which is demonstrated by this upgraded example. @GallLeo pls. create new reference results.
    - Updated reference files?

  • Release notes check: All classes mentioned which could lead to result changes in user models?
    @GallLeo could you please feed the explanation to the release notes? Thx a lot!


Useful Links

Current comparison report:
https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/comparison_report_overview.html
-> Reference result test -> Comparison

Comparison signal definitions:
https://github.com/modelica/ModelicaStandardLibrary/tree/master/Modelica/Resources/Reference/Modelica
https://github.com/modelica/ModelicaStandardLibrary/tree/master/ModelicaTest/Resources/Reference/ModelicaTest

Reference results:
https://github.com/modelica/MAP-LIB_ReferenceResults

@GallLeo GallLeo added L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational example Issue only addresses example(s) V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases) labels Feb 27, 2024
@GallLeo GallLeo added this to the MSL4.1.0 milestone Feb 27, 2024
@tobolar
Copy link
Contributor

tobolar commented Mar 1, 2024

All three points fine to me.
@AHaumer after checking the points, you can please tick them all.

@AHaumer
Copy link
Contributor

AHaumer commented Mar 1, 2024

@tobolar I won't tick the points, @GallLeo will do that as soon as he has created new reference results.

MatthiasBSchaefer added a commit to MatthiasBSchaefer/MAP-LIB_ReferenceResults that referenced this issue Mar 19, 2024
GallLeo added a commit to modelica/MAP-LIB_ReferenceResults that referenced this issue Oct 21, 2024
@GallLeo
Copy link
Contributor Author

GallLeo commented Oct 21, 2024

@Esther-Devakirubai Can you please, whether the release notes mention EddyCurrentBrake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Issue only addresses example(s) L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases)
Projects
None yet
Development

No branches or pull requests

3 participants