Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move conditional heat port models to Modelica.Thermal.HeatTransfer.Interfaces #359

Open
modelica-trac-importer opened this issue Jan 14, 2017 · 14 comments
Open

Move conditional heat port models to Modelica.Thermal.HeatTransfer.Interfaces #359

modelica-trac-importer opened this issue Jan 14, 2017 · 14 comments
Assignees
@christiankral @AHaumer
Labels
L: Electrical.Analog Issue addresses Modelica.Electrical.Analog L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes task General work that is not related to a bug or feature

Comments

@modelica-trac-importer
Copy link

Reported by christiankral on 21 Apr 2010 15:44 UTC
The conditional heat port models Modelica.Electrical.Analog.Interfaces.ConditionalHeatPort and Modelica.Electrical.MultiPhase.Interfaces.ConditionalHeatPort are not specific for electrical systems. Since these conditional heat port models can be applied to any model with one or more conditional heatports, the location in the electrical domain is not correct. Therefore, both conditional heat port models shall be moved to Modelica.Thermal.HeatTransfer.Interfaces when the next conversion script is due.

Example: Conditional heat port models shall also be applied in Modelica.Magnetic.

Migrated-From: https://trac.modelica.org/Modelica/ticket/359
@modelica-trac-importer modelica-trac-importer added L: Thermal.HeatTransfer Issue addresses Modelica.Thermal.HeatTransfer task General work that is not related to a bug or feature labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by AHaumer on 22 Apr 2010 10:07 UTC
partly resolved by e34dfbd:
PartialELementaryConditionalHeatPort and PartialConditionalHeatPort defined in Thermal.HeatTransfer.Interfaces - Electrical.Analog could use that / extend from that!
Electrical.MultiPhase has a special ConditionalHeatPort, adapted for the m phases - would leave this model in MultiPhase.
Used the ConditionalHeatPorts in Mechanics:
Rotational.Damper, SpringDamper, ElastoBacklash, BearingFriction, Brake need some testing.
Rotational.Clutch, OneWayClutch, LossyGear, GearBox: not yet implemented
Translational.Damper, SpringDamper, ElastoGap, SupportFriction, Brake need some testing.
Translational.MassWithStopAndFriction: not yet implemented.
Are there other components (MultiBody?) that would need a ConditionalHeatPort?

@modelica-trac-importer
Copy link
Author

Comment by AHaumer on 22 Apr 2010 16:46 UTC
Summary:
Done: Thermal.HeatTransfer.Interfaces.PartialElementaryConditionalHeatPort
Electrical.MultiPhase.Interfaces.ConditionalHeatPort remains in MultiPhase.
Electrical.Analog could use / extend from that.

@modelica-trac-importer
Copy link
Author

Modified by AHaumer on 27 Apr 2010 19:33 UTC

@modelica-trac-importer modelica-trac-importer added L: Electrical.Analog Issue addresses Modelica.Electrical.Analog and removed L: Thermal.HeatTransfer Issue addresses Modelica.Thermal.HeatTransfer labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by clauss on 29 Apr 2010 12:47 UTC
Electrical.Analog models changed: use now Thermal.HeatTransfer.Interfaces.PartialElementaryConditionalHeatPort.
Electrical.Analog.Interfaces.ConditionalHeatPort removed

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 29 Apr 2010 13:17 UTC
Clauss please reintroduce the deleted Electrical.Analog.Interfaces.ConditionalHeatPort (2deef6f) again as MSL3.2 is a backward compatible release. Deleting components from the library will break user models. When you done you can leave this ticket open as a reminder and when the next MSL with conversion script comes you can delete it but also have to provide a conversion script entry.

@modelica-trac-importer modelica-trac-importer added the P: highest Highest priority issue label Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by clauss on 30 Apr 2010 07:58 UTC
Electrical.Analog.Interfaces.ConditionalHeatPort reintroduced, done.

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 30 Apr 2010 08:35 UTC
Electrical.Analog.Interfaces.ConditionalHeatPort reintroduced in d887b5c.

@modelica-trac-importer modelica-trac-importer removed the P: highest Highest priority issue label Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by christiankral on 4 May 2010 13:37 UTC
There is still an non backwards compatible change in the Analog package of the MSL 3.2. Even if the conditional heat port has been re-introduced in Electrical.Analog, the models are NOT using these heat ports. Instead the non compatible heat ports of Modelica.Thermal.HeatTransfer.Interfaces.PartialElementaryConditionalHeatPort are used.

Result: Example Modelica.Magnetic.FundamentalWave.Examples.Components.EddyCurrentLosses is broken and other user specific models may not be working, too.

The partial original implementation of the heat ports **has to be established! **

@modelica-trac-importer
Copy link
Author

Comment by clauss on 5 May 2010 07:08 UTC
done, original implementation established, above mentioned example tested.

@modelica-trac-importer
Copy link
Author

Modified by dietmarw on 13 Sep 2010 23:16 UTC

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 1 Aug 2015 21:36 UTC
Milestone renamed

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 1 Aug 2015 21:39 UTC
Milestone renamed

@modelica-trac-importer modelica-trac-importer added this to the MSL_next-MAJOR-version milestone Jan 14, 2017
Closed
@beutlich beutlich mentioned this issue Oct 5, 2017
Closed
@beutlich beutlich added the L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes label Jan 2, 2018
@christiankral
Copy link
Contributor

There was the duplicate ticket #2312 introduced which summarizes some aspects on the duplicate conditional heat ports.

@christiankral christiankral mentioned this issue Jun 26, 2019
Merged
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Aug 18, 2019
@beutlich
refs modelica#359: Convert ConditionalHeatPort
ee3f519
@beutlich beutlich mentioned this issue Aug 18, 2019
Closed
@beutlich beutlich self-assigned this Aug 18, 2019
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Aug 18, 2019
@beutlich
refs modelica#359: Convert ConditionalHeatPort
9f78998
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Aug 18, 2019
@beutlich
refs modelica#359: Fix package name
b5254db
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Aug 18, 2019
@beutlich
refs modelica#359: Fix package name
3e7a414
@beutlich
Copy link
Member

Removing milestone for reasons given in #3097 (comment).

@beutlich beutlich removed this from the MSL4.0.0 milestone Sep 20, 2019
@beutlich beutlich removed their assignment May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christiankral christiankral

@AHaumer AHaumer

Labels
L: Electrical.Analog Issue addresses Modelica.Electrical.Analog L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes task General work that is not related to a bug or feature
Projects
None yet
Milestone
No milestone
6 participants
@christiankral @AHaumer @beutlich @kristinmajetta @modelica-trac-importer @ECClauss