-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename parameters of Modelica.Mechanics.MultiBody.Visualizers.Plane #2485
Comments
You are right.
Then:
|
Please do not make such changes without larger discussion. Therefore, if you make changes, do it the other way round, so replace lengthDirection by direction_x or something like that. |
I feel more comfortable with the names I proposed above. But let us discuss it in larger group. |
If you consider it now as a mistake, we really should have a GitHub issue for such kind of issues. Otherwise, we will never find out or remember. |
…mponent 'Plane' to 'Rectangle'; and B) refs #2485: In Modelica.Mechanics.MultiBody.Visualizers.Rectangle renamed components parameters
@tobolar I set the milestone to MSL4.0.0 in case we want to do some renaming. Can you please propose your changes fixing the "mistakes" in the MultiBody lib? |
Parameters of
Modelica.Mechanics.MultiBody.Visualizers.Plane
are labeled axis_[xy], length_[xy] and n[xy]. Setting axis_x to {0,1,0} and axis_y to {1,0,0} might cause some confusion. I rather would like to use the same naming convention asModelica.Mechanics.MultiBody.Visualizers.FixedShape
do, e.g., renameFor the discretization parameters I am not that sure and simply propose
See #2424.
The text was updated successfully, but these errors were encountered: