Skip to content

Add missing eventsource-parser dependency #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alvarosevilla95
Copy link

@alvarosevilla95 alvarosevilla95 commented Jun 27, 2025

Motivation and Context

The dependency is used here, but not explicitly included as a dependency. This breaks builds, at least on pnpm based setups.

How Has This Been Tested?

pnpm build now works

Breaking Changes

none

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@ihrpr
Copy link
Contributor

ihrpr commented Jun 27, 2025

Thank you for contributing to MCP Typescript SDK, there is already PR addressing this issue, closing this one as duplicate

@ihrpr ihrpr closed this Jun 27, 2025
@alvarosevilla95
Copy link
Author

ah nice, missed that one 😅

@alvarosevilla95 alvarosevilla95 deleted the eventsource-parser branch June 27, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants