Close SSE connection for request in Streamable Http Server implementation #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspahrsummers
approved these changes
Apr 8, 2025
Comment on lines
+364
to
+365
| // If the message is a response, use the request ID from the message | ||
| requestId = message.id; |
There was a problem hiding this comment.
Could we instead ensure that relatedRequestId is set for responses? (Although this is a good backup if it's not possible to guarantee.)
There was a problem hiding this comment.
I don't see a way to always guarantee that relatedRequestId is set for request, I'd leave this as a backup
…-connection-close
…-connection-close
…-connection-close
…-connection-close
…-connection-close
…-connection-close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing connection closing, noticed when writing examples of server and client. When sending POST with list tools request, noticed that the connection still alive. The root cause was that we were looking at
relatedRequestIdinstead ofmessage.idfor the response. Response would not haverelatedRequestId, only notifications will have it.Follow up
(form stacked PR)