Skip to content

Send initialized notification from client instead of server #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

Send initialized notification from client instead of server #85

merged 1 commit into from
Apr 21, 2025
+130 −12

Conversation

mattt
Copy link
Contributor

@mattt mattt commented Apr 21, 2025

Resolves #84

@mattt mattt mentioned this pull request Apr 21, 2025
Closed
stallent
stallent approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@stallent stallent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love. I have this exact change in my fork and should have opened a PR.

@mattt mattt merged commit 25dee3b into main Apr 21, 2025
4 checks passed
@mattt mattt deleted the mattt/initialized-notification branch April 21, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stallent stallent stallent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: notifications/initialized should be sent from client, not server
2 participants
@mattt @stallent