Add timeout parameter to Client.send method (#35) #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add requestTimedOut error in MCPError * Set default timeout duration to 10 seconds * Add timeoutTask to remove a request if it is still pending after timeout duration * Modify Client.ping to adopt to parameter change in Client.send * Add related test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Motivation and Context
This PR implements feature requested in #35.
How Has This Been Tested?
I ran and passed all existing test cases plus my newly created ones.
Breaking Changes
There are no breaking changes to the
Client.sendmethod, only adding a default timeout of 10 seconds.Types of changes
Checklist
Additional context