Skip to content

Update transports to send and receive data instead of strings #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2025

Conversation

mattt
Copy link
Contributor

@mattt mattt commented Apr 3, 2025

Resolves #31

This PR makes a breaking change to the Transport protocol. However, most API callers interact with StdioTransport, so unless they've implemented their own custom transport, existing usage won't be affected.

@mattt mattt force-pushed the mattt/transport-data branch from eb0aec3 to d6d5d43 Compare April 3, 2025 11:34
@mattt mattt force-pushed the mattt/transport-data branch from d6d5d43 to d90632c Compare April 3, 2025 11:40
@mattt mattt merged commit a9bcbf9 into main Apr 3, 2025
1 check passed
@mattt mattt deleted the mattt/transport-data branch April 3, 2025 11:42
devyhan pushed a commit to devyhan/swift-sdk that referenced this pull request Apr 4, 2025
…ontextprotocol#42)

* Update transports to send and receive data instead of strings

* Rename MockTransport helper methods

* Adopt Task.sleep(for:...) instead of variant taking nanoseconds

* Update comment

* Revert inadvertant change to visibility of send method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transport using String type results in extra memory copies
1 participant