Fix/decode tool call #36
Merged
+38
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equired parameters to properly decode from null, which wouldn't be possible when decoding from the 'null' JSON encoding directly.
mattt
approved these changes
Mar 31, 2025
|
This looks great, @adamwulf. Thank you for your help with all of this, and for your patience as we got this all sorted. |
|
Thanks for working through it with me! 🙌 |
devyhan
pushed a commit
to devyhan/swift-sdk
that referenced
this pull request
Apr 4, 2025
* Adding unit test * Decode entire request to strongly typed Method call. This allows NotRequired parameters to properly decode from null, which wouldn't be possible when decoding from the 'null' JSON encoding directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When receiving a request for ListTools, if the json omits the
params, then the tool handler will fail to decode the request. TheListToolsrequest does decode with this json format, however the ListTools.Parameters does not decode theparamsjson value (null) because theNotRequiredis handled when decoding the method not when decoding the parameters directly.How Has This Been Tested?
test added. If commit with the test is checked out, then the test will fail. the following commit contains the fix.
Breaking Changes
Types of changes
Checklist
Additional context