Improve NetworkTransport and add test coverage #108
Merged
+1,224
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my experience, the existing
NetworkTransport
implementation hasn't been super reliable. In iMCP, users have observed random disconnections, connection hangs, and inconsistent behavior during network transitions.This PR implements a robust connection management system to address these reliability issues:
This PR also adds test coverage to
NetworkTransport
, which is a big win. Getting that to work was a bit tedious, as it required defining an internal protocol to match theNWConnection
(final class
). But I suppose it wasn't any more onerous than the contortions we needed to mock the Foundation URL Loading System 🥲Anyway, with these changes, local builds of iMCP are working much more consistently
Footnotes
I suppose we could use
Ping
for this, but it seemed easier to drop down from the protocol layer to the transport layer for liveness checks. ↩