Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Puppeteer readme #47

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

executeautomation
Copy link
Contributor

Description

Updated the readme with the usage of the puppeteer plugin

Server Details

NA

Motivation and Context

The detail was missing and needed for beginners.

How Has This Been Tested?

Tested in my local machine and it works

Breaking Changes

NA

Types of changes

Just readme file change

Checklist

  • [ y] I have read the MCP Protocol Documentation
  • My server follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

"mcpServers": {
"puppeteer": {
"command": "npx",
"args": ["-y", "@modelcontextprotocol/server-puppeteer", "http://example.com"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think puppeteer server takes a URL in the args. It's passed in by calling the exposed tool functions.

Seems like you should drop the third "http://example.com" arg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes updated the same, thanks for the comments @sean-lynch !

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The comment is exactly right—please remove the extra arg, and we can get this merged in.

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@jspahrsummers jspahrsummers merged commit 9100b20 into modelcontextprotocol:main Nov 26, 2024
HarleyCoops pushed a commit to HarleyCoops/ClaudeServers that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants