Fix #3137: Memory MCP open_nodes returns empty relations array despit#3375
Open
danielalanbates wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Fix #3137: Memory MCP open_nodes returns empty relations array despit#3375danielalanbates wants to merge 1 commit intomodelcontextprotocol:mainfrom
open_nodes returns empty relations array despit#3375danielalanbates wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
…s in openNodes results The openNodes method was only returning relations where both endpoints were in the requested entity set (using &&). This prevented graph traversal from specific nodes without fetching the entire graph. Changed the filter logic to use || instead of &&, so openNodes now returns: - Outgoing relations (where the entity is the source) - Incoming relations (where the entity is the destination) This matches standard graph database behavior and enables efficient graph traversal by returning all edges connected to queried nodes. Updated tests to reflect the new expected behavior where openNodes returns all connected relations for the requested entities. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3137
Summary
This PR fixes: Memory MCP
open_nodesreturns empty relations array despite entity having relations in graphChanges
Testing
Please review the changes carefully. The fix was verified against the existing test suite.
This PR was created with the assistance of Claude Haiku 4.5 by Anthropic | effort: low. Happy to make any adjustments!
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license (contributor license agreement).