Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced hyphen with underscore in Sqlite & Sentry tools.. #279

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Replaced hyphen with underscore in Sqlite & Sentry tools.. #279

merged 4 commits into from
Dec 9, 2024

Conversation

rakesh-eltropy
Copy link

Description

Sqlite and Sentry MCP servers are not working of Amzaon Nova models as tool names do not accept hyphen in the name. It seems to be logical to me to have some sort of standard convention in the tool names. I checked all MCP Servers, all seems to follow tool names convention with this regular expression [a-zA-Z][a-zA-Z0-9_]* other than Sqlite and Sentry. I have replaced hyphen with underscore in these MCP servers.

Server Details

  • Server: Sqlite, Sentry
  • Changes to: tools

Motivation and Context

Sqlite and Sentry MCP servers are not working of Amzaon Nova models as tool names do not accept hyphen in the name. It seems to be logical to me to have some sort of standard convention in the tool names. I checked all MCP Servers, all seems to follow tool names convention with this regular expression [a-zA-Z][a-zA-Z0-9_]* other than Sqlite and Sentry. I have replaced hyphen with underscore in these MCP servers.

How Has This Been Tested?

I have tested the Sqlite MCP server with MCP client (https://github.com/rakesh-eltropy/mcp-client).

Breaking Changes

NA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

NA

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine as a quick mitigation, but it's also probably reasonable to expect clients to perform sanitization as needed for the models they're using—MCP won't be able to track all restrictions imposed by different providers.

Thanks for the fix!

@jspahrsummers jspahrsummers merged commit f905115 into modelcontextprotocol:main Dec 9, 2024
23 checks passed
laith-abood pushed a commit to laith-abood/mcp-claude that referenced this pull request Jan 13, 2025
Replaced hyphen with underscore in Sqlite & Sentry tools..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants