You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
git: git_show fails on a commit that touches a non-UTF-8 file #4997
git_show decodes each patch as strict UTF-8, so a commit that changes a Latin-1 (or other non-UTF-8) file fails the whole call with a decode error.
Where it is pinned
src/git/tests/test_protocol.py: test_git_show_non_utf8_patch_is_decode_error, added in #4974 (Wave 1 of #4857). Each of these tests carries a KNOWN BUG marker: it asserts the current, wrong behavior, so the fix has to change it.
Expected
Non-UTF-8 content is decoded with replacement (or shown as binary), and the rest of the commit is shown.
Done when
The behavior above is fixed, in the legacy-era (2025-11-25) server on SDK 1.x.
The pinning tests assert the correct behavior, and their KNOWN BUG markers are gone.
Activity
cliffhall commentedon Oct 5, 2026
Fixed by #5029, merged into
v2/main(Wave 6 of #5004).fix(git): print git_show in git's format and decode non-UTF-8 patches