Fix JSON-RPC notification format in Streamable HTTP transport#91
Merged
koic merged 1 commit intomodelcontextprotocol:mainfrom Jul 28, 2025
Merged
Conversation
Update send_notification method to properly construct JSON-RPC notification objects with jsonrpc version and method fields. This ensures notifications conform to the JSON-RPC 2.0 specification when sent over HTTP transport. https://www.jsonrpc.org/specification#notification Another goal is to standardise the `send_notification` interface. Before the revision, it was sufficient to pass the method and parameters in the case of stdio. However, in the case of Streamable, a hash based on the JSON-RPC specification must be passed.
koic
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Update send_notification method to properly construct JSON-RPC notification objects with jsonrpc version and method fields.
This ensures notifications conform to the JSON-RPC 2.0 specification when sent over HTTP transport.
https://www.jsonrpc.org/specification#notification
Another goal is to standardise the
send_notificationinterface.Before the revision, it was sufficient to pass the method and parameters in the case of stdio.
However, in the case of Streamable, a hash based on the JSON-RPC specification must be passed.
How Has This Been Tested?
It is covered by existing tests for this case.
Breaking Changes
There's a potential impact on clients receiving notifications, because this modification will structure them.
Types of changes
Checklist
Additional context