Add define_custom_method to define custom methods (and notifications)#75
Merged
atesgoral merged 1 commit intomodelcontextprotocol:mainfrom Jul 15, 2025
Merged
Conversation
91a188c to
6ec56fb
Compare
6ec56fb to
1ed3139
Compare
koic
approved these changes
Jul 15, 2025
Member
koic
left a comment
There was a problem hiding this comment.
If I were to raise one minor concern, it would be whether supporting methods outside the MCP specification is entirely suitable. That said, based on the explanation in the PR, it seems there’s a clear rationale for needing such functionality.
Both the documentation and the implementation look solid 👍
topherbullock
approved these changes
Jul 15, 2025
Contributor
topherbullock
left a comment
There was a problem hiding this comment.
yeah, @koic I had a similar feeling initially about extending MCP spec with custom methods. I like that this allows users to add custom capabilities ( that could be proposed as additions to the spec if they prove a useful extension ) without needing to extend Server and override a lot of internals to achieve the same goal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Adds
define_custom_methodto Server to allow definition of custom methods (outside the MCP spec). Method blocks that returnnilbecome custom notifications.Motivation and Context
MCP supports both servers and clients to send notifications. And notifications are not limited to what's defined by the spec.
This PR adds flexibility for servers to receive custom method calls and notifications from clients/hosts.
Servers can implement cutting-edge MCP methods before this gem implements them.
Custom notifications from host to server allow use cases like diagnostic logging, capturing of multimodal LLM transcripts, etc. by piggybacking on MCP instead of implementing custom endpoints.
How Has This Been Tested?
New unit tests
Breaking Changes
None
Types of changes
Checklist
Additional context