Fix tool error handling to follow MCP spec#165
Merged
koic merged 1 commit intomodelcontextprotocol:mainfrom Oct 22, 2025
Merged
Fix tool error handling to follow MCP spec#165koic merged 1 commit intomodelcontextprotocol:mainfrom
koic merged 1 commit intomodelcontextprotocol:mainfrom
Conversation
atesgoral
reviewed
Oct 12, 2025
koic
reviewed
Oct 15, 2025
Member
|
I've left one small comment, but overall it looks good to me. Can you address it and squash the commits in to one? |
Member
|
@Jflick58 ping. |
Contributor
Author
|
@koic sorry have been sick. I'll get this buttoned up |
Tool execution errors now return successful responses with isError: true instead of JSON-RPC protocol errors, per the MCP specification. This allows clients to distinguish between protocol-level errors and tool execution errors, providing better error context. Fixes modelcontextprotocol#159
f383442 to
389cc2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool execution errors now return successful responses with isError: true
instead of JSON-RPC protocol errors, per the MCP specification.
Motivation and Context
This allows clients to distinguish between protocol-level errors and
tool execution errors, providing better error context.
Fixes #159
How Has This Been Tested?
Updated unit tests to support new error behavior. All existing tests passing.
Breaking Changes
If client libs are parsing the error message for the specific tool call error, then they will likely get a parser error due to the change of the error structure.
Current behavior:
Updated behavior (matches spec and readme):
Types of changes
Checklist