-
Notifications
You must be signed in to change notification settings - Fork 582
feat(infra): Add Pulumi-based Kubernetes deployment infrastructure #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comprehensive analysis of MCP Registry deployment setup identifying: - Critical issue with placeholder nginx container vs actual registry - Security considerations and monitoring gaps - High availability and reliability improvements needed - Prioritized recommendations for production readiness 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Having a meeting today at 5pm UK to decide how we proceed with this or #242. See Discord for details. |
maxisbey
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #227
How is this different to #190
Testing
I've got this running well:
Claude written architecture and security review
Deployment Review & Assessment
Current Architecture Strengths
Pulumi IaC Approach
pkg/directorySecurity Fundamentals
appuserwith UID 10001)Critical Issues & High-Priority Improvements
1. Production Deployment Not Ready 🚨
The registry deployment uses
nginx:alpineplaceholder image instead of the actual MCP registry:deploy/pkg/k8s/registry.go:67- TODO comments indicate incomplete setupFix: Build and publish actual registry container image to GHCR, update deployment
2. Database Security Considerations 🔒
Note: MongoDB is not exposed externally (ClusterIP service), so this is not a critical security risk but should be addressed for production.
3. Monitoring & Observability Gaps 📊
4. High Availability & Reliability⚠️
Recommended Improvements
Immediate (High Priority)
Medium Priority
3. Add Monitoring Stack - Prometheus, Grafana deployment
4. Security Hardening (Nice to Have) - RBAC policies, Network Policies, Pod Security Standards
5. CI/CD Pipeline Enhancement - Container image building/publishing, automated deployment
Lower Priority
6. High Availability - MongoDB replica set, HPA for registry pods
7. Operational Excellence - Kubernetes dashboard, cost optimization
Configuration Issues
deploy/Pulumi.prod.yaml:4-5example.com)The deployment setup shows good architectural foundations but needs significant work before production readiness. The most critical issue is the placeholder nginx container - priority should be completing the actual registry application deployment before addressing the other improvements. Security measures like RBAC and Network Policies are nice to have but not strictly necessary given that MongoDB is not exposed externally.
🤖 Generated with Claude Code
Metadata
Working towards #91