Repository navigation
Code review found 2 potential issues
Found 6 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | VERSIONING.md:11 |
nit: The public-API boundary is vacuous as written: it covers "signatures, and behavior documented ... in its API Refere |
| 🟡 Nit | DEPENDENCY_POLICY.md:11 |
[quality] nit: The "When a floor moves" section restates AGENTS.md's dependency-floor rule ("Don't raise dependency floo |
Annotations
Check warning on line 11 in VERSIONING.md
claude / Claude Code Review
nit: The public-API boundary is vacuous as written: it covers "signatures, and behavior documented ... in its API Reference" and carves out "undocumented modules", but the repo's reference generator (scripts/docs/gen_ref_pages.py) auto-writes an API Refer
nit: The public-API boundary is vacuous as written: it covers "signatures, and behavior documented ... in its API Reference" and carves out "undocumented modules", but the repo's reference generator (scripts/docs/gen_ref_pages.py) auto-writes an API Reference page for every non-underscore module of both packages (PACKAGES loop skips only components starting with '_' and the mcp.types alias in EXCLUDED). There are no undocumented non-underscore modules, so the carve-out matches nothing and the co
Check warning on line 11 in DEPENDENCY_POLICY.md
claude / Claude Code Review
[quality] nit: The "When a floor moves" section restates AGENTS.md's dependency-floor rule ("Don't raise dependency floors for CVEs alone... Only raise a floor when the SDK needs functionality from the newer version, and don't add SDK code to work around
[quality] nit: The "When a floor moves" section restates AGENTS.md's dependency-floor rule ("Don't raise dependency floors for CVEs alone... Only raise a floor when the SDK needs functionality from the newer version, and don't add SDK code to work around a dependency's vulnerability") as a second free-standing source of truth, down to citing the identical two references (Kludex/uvicorn#2643 and python-sdk#1552), with no cross-reference in either direction.