-
Notifications
You must be signed in to change notification settings - Fork 1.8k
tests: use inline_snapshot.Is
on parametrized test
#945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Looks like the tests are still failing though? |
That one failure looks like just a flaky test. |
Now the test is fixed... But it's failing correctly... 😅 The |
In progress in pydantic/pydantic-core#1719, but anyway this will only be included in 2.12. |
If you access the MCP server without the trailing slash, it will redirect you to a URL with the slash added. |
Are you saying this is working as expected? |
I have no idea how the test is supposed to work, TBH. I just observed a lot of redirects happening in the test suite when the forward slash is missing from the end of the URI. |
It's a Starlette thing. There's another PR that fixes the redirect behavior. |
cc @agronholm
This PR just uses
inline_snapshot
s properly on a parametrized test.