Skip to content

fix for SSE URL handling when a server name is specified #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

fix for SSE URL handling when a server name is specified #597

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
283f43c
fix for SSE URL handling when a server name is specified
aarora79 Apr 28, 2025
ec9dcc1
ruff formatting changes
aarora79 Apr 28, 2025
f7d9e88
ruff formatting changes
aarora79 Apr 28, 2025
4eb8521
make ruff happy
aarora79 Apr 28, 2025
851c34b
Merge branch 'main' into main
aarora79 May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ruff formatting changes
  • Loading branch information
@aarora79
aarora79 committed Apr 28, 2025
commit ec9dcc1f35e63f480f642b8df3a0ee45a6547baf
22 changes: 11 additions & 11 deletions tests/client/test_sse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,26 @@

@pytest.mark.parametrize(
"base_url,endpoint,expected",
[
[
# Additional test cases to verify behavior with different URL structures
(
"https://mcp.example.com/weather/sse",
"/messages/?session_id=616df71373444d76bd566df4377c9629",
"https://mcp.example.com/weather/messages/?session_id=616df71373444d76bd566df4377c9629"
"https://mcp.example.com/weather/sse",
"/messages/?session_id=616df71373444d76bd566df4377c9629",
"https://mcp.example.com/weather/messages/?session_id=616df71373444d76bd566df4377c9629",
),
(
"https://mcp.example.com/weather/clarksburg/sse",
"/messages/?session_id=616df71373444d76bd566df4377c9629",
"https://mcp.example.com/weather/clarksburg/messages/?session_id=616df71373444d76bd566df4377c9629"
"https://mcp.example.com/weather/clarksburg/sse",
"/messages/?session_id=616df71373444d76bd566df4377c9629",
"https://mcp.example.com/weather/clarksburg/messages/?session_id=616df71373444d76bd566df4377c9629",
),
(
"https://mcp.example.com/sse",
"/messages/?session_id=616df71373444d76bd566df4377c9629",
"https://mcp.example.com/messages/?session_id=616df71373444d76bd566df4377c9629"
"https://mcp.example.com/sse",
"/messages/?session_id=616df71373444d76bd566df4377c9629",
"https://mcp.example.com/messages/?session_id=616df71373444d76bd566df4377c9629",
),
],
)
def test_custom_url_join(base_url, endpoint, expected):
"""Test the custom_url_join function with messages endpoint and session ID."""
result = custom_url_join(base_url, endpoint)
assert result == expected
assert result == expected
Loading