Repository navigation
Accept boolean sub-schemas in 2025-11-25 tool schema properties - #3354
Merged
Merged
Claude / Claude Code Review
completed
Aug 21, 2026 in 5m 39s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/mcp-types/mcp_types/_v2025_11_25/__init__.py:1361 |
nit: 'dict[str, Any] | bool' under pydantic smart union lax-coerces bool-ish scalars (1, 0, "true", "yes", "on", 1.0) i |
Annotations
Check warning on line 1361 in src/mcp-types/mcp_types/_v2025_11_25/__init__.py
claude / Claude Code Review
nit: `dict[str, Any] | bool` under pydantic smart union lax-coerces bool-ish scalars (1, 0, "true", "yes", "on", 1.0) into booleans, silently rewriting invalid property sub-schemas instead of rejecting them (same union at line 1379 in OutputSchema; WireMo
nit: `dict[str, Any] | bool` under pydantic smart union lax-coerces bool-ish scalars (1, 0, "true", "yes", "on", 1.0) into booleans, silently rewriting invalid property sub-schemas instead of rejecting them (same union at line 1379 in OutputSchema; WireModel is not strict-mode)
Loading