Repository navigation
Acknowledge notification POSTs with 202 on the 2026-07-28 HTTP entry - #3326
Merged
Merged
Claude / Claude Code Review
completed
Aug 17, 2026 in 8m 35s
Code review found 1 new issue (2 earlier findings still open)
Found 2 candidates, confirmed 3: 1 posted in this review, 2 from earlier reviews still open. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 3 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | tests/interaction/transports/test_hosting_http_modern.py:171 |
[quality] nit: the new test's docstring claims "(neither is read before the modern entry answers)" about the json_respon |
Annotations
Check warning on line 171 in tests/interaction/transports/test_hosting_http_modern.py
claude / Claude Code Review
[quality] nit: the new test's docstring claims "(neither is read before the modern entry answers)" about the json_response/stateless_http parametrization, but json_response IS read before the notification 202 — handle_modern_request's Accept gate (`if n
[quality] nit: the new test's docstring claims "(neither is read before the modern entry answers)" about the json_response/stateless_http parametrization, but json_response IS read before the notification 202 — handle_modern_request's Accept gate (`if not has_json or (not json_response and not has_sse)`, src/mcp/server/_streamable_http_modern.py:396) evaluates it ahead of _acknowledge_notification, and it genuinely changes the answer: with json_response=False a notification POST whose Accept l
Loading