Repository navigation
Conversation
Contributor
|
Thanks for the PR, and sorry it sat here without a proper review. We're closing most of the open PR backlog. v2 is out and changed a lot of the SDK, so many older PRs no longer apply as written, and we're a small team that realistically doesn't have the capacity to work through the rest. If this still matters to you on v2, the most useful thing you can do is open an issue (or comment on the existing one) with your use case and a repro. Hearing why it matters to you is what we use to decide what to prioritise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
resources/readandprompts/getare traced by the same request-level server middleware as tools.prompts/getgetsgen_ai.prompt.name, whileresources/readcurrently carries the common MCP attributes without adding the resource URI to the span name orgen_ai.*attributes.Why it changed
Issue #766 asks where instrumentation for resources and prompts should happen. The docs already covered tool spans, but resource and prompt behavior was less explicit.
How it was validated
uv run pytest tests/docs_src/test_opentelemetry.pyuv run pytest tests/docs_src/test_shape.pyuv run pytest tests/server/test_otel.pyuv run ruff check docs_src/opentelemetry tests/docs_src/test_opentelemetry.pyuv run ruff format --check docs_src/opentelemetry tests/docs_src/test_opentelemetry.pyuv run pyright docs_src/opentelemetry tests/docs_src/test_opentelemetry.pyuv run mkdocs build --strictRelated issue
Refs #766
Disclosure: AI assistance was used while preparing this PR; I reviewed the changes and take responsibility for them.