-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix: send params as empty object for list methods without cursor #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
03b89e9
fix: send params as empty object for list methods without cursor
felixweinberger 7db0e25
feat: deprecate cursor parameter in favor of params for list methods
felixweinberger b779c12
test: add params parameter tests and precedence verification
felixweinberger a98c4f7
refactor: use parametrized tests to reduce test duplication
felixweinberger 3217282
refactor: add @overload decorators and @deprecated for list methods
felixweinberger d4b0608
fix: flip order of @overload & @deprecated to match docs
felixweinberger 28c6f0d
fix: improve deprecation warning string
felixweinberger 6daf63b
Merge branch 'main' into fweinberger/validation-consistency
felixweinberger ee989cf
fix: remove unnecessary lint ignore
felixweinberger 1827420
Merge branch 'main' into fweinberger/validation-consistency
felixweinberger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.