Skip to content

Comments

Use mcp instead of fastmcp CLI as command in "mcp install"#118

Merged
dsp-ant merged 2 commits intomodelcontextprotocol:mainfrom
samefarrar:mcp-instead-of-fastmcp-install
Jan 2, 2025
Merged

Use mcp instead of fastmcp CLI as command in "mcp install"#118
dsp-ant merged 2 commits intomodelcontextprotocol:mainfrom
samefarrar:mcp-instead-of-fastmcp-install

Conversation

@samefarrar
Copy link
Contributor

Currently, when you run mcp install ..., it adds uv run --with fastmcp fastmcp ... to the Claude config file.
We don't need to do this anymore since fastmcp functionality has been merged into the main mcp python SDK.
Instead, we can make mcp install ... run uv run --with mcp mcp ....

Motivation and Context

Running with --with fastmcp fastmcp continues to rely on an unnecessary external dependency when this functionality has been merged into the mcp cli command.

How Has This Been Tested?

I added a test to check that the command added to the Claude config can run (with --help). This does pass with the fastmcp version but requires an additional external dependency.

Breaking Changes

No, even previous installs will still work. All tests continue to pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for trying 1.2.0rc1 and finding this!

@dsp-ant dsp-ant merged commit 21ac404 into modelcontextprotocol:main Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants