Use mcp instead of fastmcp CLI as command in "mcp install"#118
Merged
dsp-ant merged 2 commits intomodelcontextprotocol:mainfrom Jan 2, 2025
Merged
Conversation
…(/not installed). We can just run it with mcp.
dsp-ant
approved these changes
Jan 2, 2025
Member
dsp-ant
left a comment
There was a problem hiding this comment.
Good catch! Thank you for trying 1.2.0rc1 and finding this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when you run
mcp install ..., it addsuv run --with fastmcp fastmcp ...to the Claude config file.We don't need to do this anymore since fastmcp functionality has been merged into the main mcp python SDK.
Instead, we can make
mcp install ...runuv run --with mcp mcp ....Motivation and Context
Running with
--with fastmcp fastmcpcontinues to rely on an unnecessary external dependency when this functionality has been merged into themcpcli command.How Has This Been Tested?
I added a test to check that the command added to the Claude config can run (with --help). This does pass with the fastmcp version but requires an additional external dependency.
Breaking Changes
No, even previous installs will still work. All tests continue to pass.
Types of changes
Checklist