Skip to content

Conversation

@JsFlo
Copy link
Contributor

@JsFlo JsFlo commented Feb 21, 2025

  • Updates sample project to use library version 0.3.0
  • Fixes ktor example by using .start(wait = True) similar to the plain config example
  • updates function names to conform to the kotlin style guide per the contribution guidelines (only test function names should use the backticks with spaces)

Motivation and Context

I realize there's not technically an issue on this but wasn't sure if a sample project update needed one but I wanted to try this library out but the sample was slightly outdated and the ktor example wasn't working so I updated it for my tests and figured I could put a PR to update in the project. Feel free to close this if this isn't appropriate as I'm not sure the procedure with sample updates

How Has This Been Tested?

I focused on the KTOR and plain config examples and in those cases I was able to use a basic SSE python client to make the connection get session/messages list tools. I updated the stdio example with the new library and that seems to work as before though I don't know how that's used as it immediately closes connection but that's the same behavior before and after my changes.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Copy link
Contributor

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JsFlo! Thanks for the PR! lgtm

@e5l e5l enabled auto-merge (squash) February 21, 2025 17:15
@e5l e5l disabled auto-merge February 25, 2025 08:18
@e5l e5l enabled auto-merge (squash) February 25, 2025 08:18
@e5l e5l merged commit 164d276 into modelcontextprotocol:main Feb 25, 2025
1 check passed
tinycrops pushed a commit to tinycrops/kotlin-sdk that referenced this pull request Mar 8, 2025
…col#47)

Co-authored-by: Leonid Stashevsky <e5l@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants